Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lich/Necromancer evil update #1137

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

BadAtThisGame302
Copy link
Contributor

About The Pull Request

A new antagonist that's based on necromancer, with spells focusing on the undead as well as adding new spell icons for his spells porting a few of these PRs Vanderlin-Tales-Of-Wine#53, Vanderlin-Tales-Of-Wine#25 and the files from our wonderful little downstream, aswell as the icons made by I believe @aberrantQuesrist

Why It's Good For The Game

I believe we've discussed about more antagonists and seeing as our pop has been on the downturn lately I took it upon myself to revive necromancer and put the same spin on it as the other RT servers and turn it to the lich villian.

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

@NPC1314
Copy link
Contributor

NPC1314 commented Nov 23, 2024

how does it work? A little summary would be nice

@ThePainkiller ThePainkiller added Question New features This PR introduces entirely new mechanics or features labels Nov 25, 2024
@BadAtThisGame302
Copy link
Contributor Author

how does it work? A little summary would be nice

It works how it sounds, spawn as a Lich and raise skeletons to accomplish your objectives. The code goes into detail.

@NPC1314
Copy link
Contributor

NPC1314 commented Dec 16, 2024

If you fix the conflict we´ll TM

@ThePainkiller
Copy link
Contributor

Branch too stale, will need a remake of the entire PR to not conflict like Kaizoku PR did. Please reopen both ports if possible.

@ThePainkiller ThePainkiller added Merge conflict This PR won't compile due to merge conflics. Branch out of date Branch needs to be up to date with main before merging. and removed Question labels Jan 28, 2025
@BadAtThisGame302 BadAtThisGame302 removed Merge conflict This PR won't compile due to merge conflics. Branch out of date Branch needs to be up to date with main before merging. labels Jan 28, 2025
@BadAtThisGame302
Copy link
Contributor Author

Branch too stale, will need a remake of the entire PR to not conflict like Kaizoku PR did. Please reopen both ports if possible.

Fixed the conflict, what else conflicts with Kaizoku?

@ThePainkiller
Copy link
Contributor

Fixed the conflict, what else conflicts with Kaizoku?

It's not that it conflicts with Kaizoku, I put it as a point of comparison due to being made initially by an old branch

@ThePainkiller ThePainkiller added the Scheduled for testmerge This PR should be testmerged label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New features This PR introduces entirely new mechanics or features Scheduled for testmerge This PR should be testmerged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants